git-verify-pack: free pack after use and a cleanup
Plug memory leak in verify_one_pack() by freeing the struct packed_git we got from add_packed_git(). Also rename g to pack and pull an assignment out of an if statement while we're at it. Signed-off-by: Rene Scharfe <rene.scharfe@lsrfire.ath.cx> Signed-off-by: Junio C Hamano <junkio@cox.net>
Rene Scharfe committed
Aug 10, 2006 at 17:02 UTC
d0d619c8c50b90fbbd6a7e0994fde073341bf92b
1 file changed
+8
-3
verify-pack.c
+8
-3
@@ -5,7 +5,8 @@ static int verify_one_pack(const char *path, int verbose)
5
{
6
char arg[PATH_MAX];
7
int len;
8
- struct packed_git *g;
8
+ struct packed_git *pack;
9
+ int err;
10
11
len = strlcpy(arg, path, PATH_MAX);
12
if (len >= PATH_MAX)
@@ -25,10 +26,14 @@ static int verify_one_pack(const char *path, int verbose)
26
len += 4;
27
}
28
28
- if (!(g = add_packed_git(arg, len, 1)))
29
+ pack = add_packed_git(arg, len, 1);
30
+ if (!pack)
31
return error("packfile %s not found.", arg);
32
31
- return verify_pack(g, verbose);
33
+ err = verify_pack(pack, verbose);
34
+ free(pack);
35
+
36
+ return err;
37
}
38
39
static const char verify_pack_usage[] = "git-verify-pack [-v] <pack>...";