submodule.c: use argv_array in is_submodule_modified
struct argv_array is easier to use and maintain. Signed-off-by: Stefan Beller <sbeller@google.com> Reviewed-by: Jonathan Nieder <jrnieder@gmail.com> Signed-off-by: Junio C Hamano <gitster@pobox.com>
Stefan Beller committed
Mar 24, 2017 at 17:36 UTC
d0d7fed1a2522cc82dfa934df0cdd362a66058b1
1 file changed
+2
-8
submodule.c
+2
-8
@@ -1043,12 +1043,6 @@ unsigned is_submodule_modified(const char *path, int ignore_untracked)
1043
{
1044
ssize_t len;
1045
struct child_process cp = CHILD_PROCESS_INIT;
1046
- const char *argv[] = {
1047
- "status",
1048
- "--porcelain",
1049
- NULL,
1050
- NULL,
1051
- };
1046
struct strbuf buf = STRBUF_INIT;
1047
unsigned dirty_submodule = 0;
1048
const char *line, *next_line;
@@ -1066,10 +1060,10 @@ unsigned is_submodule_modified(const char *path, int ignore_untracked)
1060
}
1061
strbuf_reset(&buf);
1062
1063
+ argv_array_pushl(&cp.args, "status", "--porcelain", NULL);
1064
if (ignore_untracked)
1070
- argv[2] = "-uno";
1065
+ argv_array_push(&cp.args, "-uno");
1066
1072
- cp.argv = argv;
1067
prepare_submodule_repo_env(&cp.env_array);
1068
cp.git_cmd = 1;
1069
cp.no_stdin = 1;