t5601: fix quotation error leading to skipped tests
One of the tests in t5601 used single quotes to delimit an argument containing spaces. However, this caused test_expect_success to be passed three arguments instead of two, which in turn caused the test name to be treated as a prerequisite instead of a test name. As there was no prerequisite called "bracketed hostnames are still ssh", the test was always skipped. Because this test was always skipped, the fact that it passed the arguments in the wrong order was obscured. Use double quotes inside the test and reorder the arguments so that the test runs and properly reflects the arguments that are passed to ssh. Signed-off-by: brian m. carlson <sandals@crustytoothpaste.net> Signed-off-by: Junio C Hamano <gitster@pobox.com>
brian m. carlson committed
Apr 26, 2015 at 20:30 UTC
d1018c2494c05e6a27ec5945902306cfb9e45b0c
1 file changed
+1
-1
t/t5601-clone.sh
+1
-1
@@ -332,7 +332,7 @@ test_expect_success !MINGW,!CYGWIN 'clone local path foo:bar' '
332
333
test_expect_success 'bracketed hostnames are still ssh' '
334
git clone "[myhost:123]:src" ssh-bracket-clone &&
335
- expect_ssh myhost '-p 123' src
335
+ expect_ssh "-p 123" myhost src
336
'
337
338
counter=0