@matheusbsbs / matheus-bagliano / commits / d164b7548a
Fork 0

git-gui: Change our initial GC hint to be an estimate

Instead of running a full git-count-objects to count all of the loose objects we can get a reasonably close approximation by counting the number of files in the .git/objects/42 subdirectory. This works out reasonably well because the SHA-1 hash has a fairly even distribution, so every .git/objects/?? subdirectory should get a relatively equal number of files. If we have at least 8 files in .git/objects/42 than it is very likely there is about 8 files in every other directory, leaving us with around 2048 loose objects. This check is much faster, as we need to only perform a readdir of a single directory, and we can do it directly from Tcl and avoid the costly fork+exec. All of the credit on how clever this is goes to Linus Torvalds; he suggested using this trick in a post commit hook to repack every so often. Signed-off-by: Shawn O. Pearce <spearce@spearce.org>

Shawn O. Pearce committed Jul 17, 2007 at 22:49 UTC d164b7548ab61e50d4404d1fbc0da3a8f6c0cc87
1 file changed +14 -5
git-gui.sh
+14 -5
@@ -2560,12 +2560,21 @@ if {[is_enabled transport]} {
2560 # -- Only suggest a gc run if we are going to stay running.
2561 #
2562 if {[is_enabled multicommit]} {
2563 - set object_limit 2000
2564 - if {[is_Windows]} {set object_limit 200}
2565 - regexp {^([0-9]+) objects,} [git count-objects] _junk objects_current
2563 + set object_limit 8
2564 + if {[is_Windows]} {
2565 + set object_limit 1
2566 + }
2567 + set objects_current [llength [glob \
2568 + -directory [gitdir objects 42] \
2569 + -nocomplain \
2570 + -tails \
2571 + -- \
2572 + *]]
2573 if {$objects_current >= $object_limit} {
2574 + set objects_current [expr {$objects_current * 256}]
2575 + set object_limit [expr {$object_limit * 256}]
2576 if {[ask_popup \
2568 - "This repository currently has $objects_current loose objects.
2577 + "This repository currently has approximately $objects_current loose objects.
2578
2579 To maintain optimal performance it is strongly recommended that you compress the database when more than $object_limit loose objects exist.
2580
@@ -2573,7 +2582,7 @@ Compress the database now?"] eq yes} {
2582 do_gc
2583 }
2584 }
2576 - unset object_limit _junk objects_current
2585 + unset object_limit objects_current
2586 }
2587
2588 lock_index begin-read