submodule: remove add_oid_to_argv()
The function 'add_oid_to_argv()' provides the same functionality as 'append_oid_to_argv()'. Remove this duplicate function and instead use 'append_oid_to_argv()' where 'add_oid_to_argv()' was previously used. Signed-off-by: Brandon Williams <bmwill@google.com> Signed-off-by: Junio C Hamano <gitster@pobox.com>
Brandon Williams committed
Apr 28, 2017 at 16:53 UTC
d1a8460caac1a19457e352a6b610b7bc89cd56d9
1 file changed
+2
-8
submodule.c
+2
-8
@@ -970,12 +970,6 @@ void check_for_new_submodule_commits(struct object_id *oid)
970
oid_array_append(&ref_tips_after_fetch, oid);
971
}
972
973
-static int add_oid_to_argv(const struct object_id *oid, void *data)
974
-{
975
- argv_array_push(data, oid_to_hex(oid));
976
- return 0;
977
-}
978
-
973
static void calculate_changed_submodule_paths(void)
974
{
975
struct rev_info rev;
@@ -989,10 +983,10 @@ static void calculate_changed_submodule_paths(void)
983
init_revisions(&rev, NULL);
984
argv_array_push(&argv, "--"); /* argv[0] program name */
985
oid_array_for_each_unique(&ref_tips_after_fetch,
992
- add_oid_to_argv, &argv);
986
+ append_oid_to_argv, &argv);
987
argv_array_push(&argv, "--not");
988
oid_array_for_each_unique(&ref_tips_before_fetch,
995
- add_oid_to_argv, &argv);
989
+ append_oid_to_argv, &argv);
990
setup_revisions(argv.argc, argv.argv, &rev, NULL);
991
if (prepare_revision_walk(&rev))
992
die("revision walk setup failed");