@matheusbsbs / matheus-bagliano / commits / d20602eec9
Fork 0

gitweb: do not choke on recursive symlink

If somebody used to advertise his repository that physically resides at /pub/lic.git/ as: git://git.example.com/pub/lic.git/ but now wants to use --base-path to allow: git://git.example.com/lic.git/ she can start git-daemon with --base-path option, like this: git-daemon --base-path=/pub --export-all During the transition, however, she would also want to allow older URL as well. One natural way to achieve that is to create a symlink: ln -s /pub /pub/pub so that a request to git://git.example.com/pub/lic.git/ is first translated by --base-path to a request to /pub/pub/lic.git/ which goes to /pub/lic.git, thanks to the symlink. So far so good. However, gitweb chokes if there is such a symlink (File::Find barfs with "/pub/pub is a recursive symbolic link"). Make the code ignore such a symlink. Signed-off-by: Junio C Hamano <gitster@pobox.com>

Junio C Hamano committed Jul 27, 2007 at 01:23 UTC d20602eec97caa8766820150eff2a07e205c44e1
1 file changed +1
gitweb/gitweb.perl
+1
@@ -1515,6 +1515,7 @@ sub git_get_projects_list {
1515
1516 File::Find::find({
1517 follow_fast => 1, # follow symbolic links
1518 + follow_skip => 2, # ignore duplicates
1519 dangling_symlinks => 0, # ignore dangling symlinks, silently
1520 wanted => sub {
1521 # skip project-list toplevel, if we get it.