ref-filter: die on parse_commit errors
The tag-contains algorithm quietly returns "does not contain" when parse_commit() fails. But a parse failure is an indication that the repository is corrupt. We should die loudly rather than producing a bogus result. Signed-off-by: Jeff King <peff@peff.net> Signed-off-by: Junio C Hamano <gitster@pobox.com>
Jeff King committed
Mar 9, 2017 at 08:29 UTC
d344d1cb8a1d1bea268ec78f5d7315381a0a6c96
1 file changed
+1
-3
ref-filter.c
+1
-3
@@ -1523,9 +1523,7 @@ static enum contains_result contains_test(struct commit *candidate,
1523
return CONTAINS_YES;
1524
}
1525
1526
- if (parse_commit(candidate) < 0)
1527
- return CONTAINS_NO;
1528
-
1526
+ parse_commit_or_die(candidate);
1527
return CONTAINS_UNKNOWN;
1528
}
1529