Insert ACTIVESTATE_STRING in Git.pm
Also add "git" to the pipe parameters, otherwise it does not work at all, as no git commands are usable out of git context. Signed-off-by: Alex Riesen <raa.lkml@gmail.com> Signed-off-by: Junio C Hamano <junkio@cox.net>
Alex Riesen committed
Jan 22, 2007 at 17:14 UTC
d3b1785f3fe681f6837a6110008af98003f675d3
1 file changed
+4
-3
perl/Git.pm
+4
-3
@@ -736,7 +736,7 @@ sub _command_common_pipe {
736
_check_valid_cmd($cmd);
737
738
my $fh;
739
- if ($^O eq '##INSERT_ACTIVESTATE_STRING_HERE##') {
739
+ if ($^O eq 'MSWin32') {
740
# ActiveState Perl
741
#defined $opts{STDERR} and
742
# warn 'ignoring STDERR option - running w/ ActiveState';
@@ -809,8 +809,9 @@ sub TIEHANDLE {
809
# FIXME: This is probably horrible idea and the thing will explode
810
# at the moment you give it arguments that require some quoting,
811
# but I have no ActiveState clue... --pasky
812
- my $cmdline = join " ", @params;
813
- my @data = qx{$cmdline};
812
+ # Let's just hope ActiveState Perl does at least the quoting
813
+ # correctly.
814
+ my @data = qx{git @params};
815
bless { i => 0, data => \@data }, $class;
816
}
817