@matheusbsbs / matheus-bagliano / commits / d48b284183

Fork 0

perl: bump the required Perl version to 5.8 from 5.6.[21]

Formalize our dependency on perl 5.8, bumped from 5.6.[12]. We already used the three-arg form of open() which was introduced in 5.6.1, but t/t9700/test.pl explicitly depended on 5.6.2. However git-add--interactive.pl has been failing on the 5.6 line since it was introduced in v1.5.0-rc0~12^2~2 back in 2006 due to this open syntax: sub run_cmd_pipe { my $fh = undef; open($fh, '-|', @_) or die; return <$fh>; } Which when executed dies on "Can't use an undefined value as filehandle reference". Several of our tests also fail on 5.6 (even more when compiled with NO_PERL_MAKEMAKER=1): t2016-checkout-patch.sh t3904-stash-patch.sh t3701-add-interactive.sh t7105-reset-patch.sh t7501-commit.sh t9700-perl-git.sh Our code is bitrotting on 5.6 with no-one interested in fixing it, and pinning us to such an ancient release of Perl is keeping us from using useful features introduced in the 5.8 release. The 5.6 series is now over 10 years old, and the 5.6.2 maintenance release almost 7. 5.8 on the other hand is more than 8 years old. All the modern Unix-like operating systems have now upgraded to it or a later version, and 5.8 packages are available for old IRIX, AIX Solaris and Tru64 systems. Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com> Acked-by: Tor Arntsen <tor@spacetec.no> Acked-by: Randal L. Schwartz <merlyn@stonehenge.com> Signed-off-by: Junio C Hamano <gitster@pobox.com>

Ævar Arnfjörð Bjarmason committed Sep 24, 2010 at 20:00 UTC d48b28418355ef41a9501eb28a82ec0b69e62a17

14 files changed +17 -6

INSTALL

+4 -4

@@ -67,10 +67,10 @@ Issues of note:

67 - A POSIX-compliant shell is required to run many scripts needed

68 for everyday use (e.g. "bisect", "pull").

70 - - "Perl" is needed to use some of the features (e.g. preparing a

71 - partial commit using "git add -i/-p", interacting with svn

72 - repositories with "git svn"). If you can live without these, use

73 - NO_PERL.

70 + - "Perl" version 5.8 or later is needed to use some of the

71 + features (e.g. preparing a partial commit using "git add -i/-p",

72 + interacting with svn repositories with "git svn"). If you can

73 + live without these, use NO_PERL.

75 - "openssl" library is used by git-imap-send to use IMAP over SSL.

76 If you don't need it, use NO_OPENSSL.

git-add--interactive.perl

@@ -1,5 +1,6 @@

1 #!/usr/bin/perl -w

3 +use 5.008;

4 use strict;

5 use Git;

git-archimport.perl

@@ -54,6 +54,7 @@ and can contain multiple, unrelated branches.

55 =cut

57 +use 5.008;

58 use strict;

59 use warnings;

60 use Getopt::Std;

git-cvsexportcommit.perl

@@ -1,5 +1,6 @@

1 #!/usr/bin/perl -w

3 +use 5.008;

4 use strict;

5 use Getopt::Std;

6 use File::Temp qw(tempdir);

git-cvsimport.perl

@@ -13,6 +13,7 @@

13 # The head revision is on branch "origin" by default.

14 # You can change that with the '-o' option.

16 +use 5.008;

17 use strict;

18 use warnings;

19 use Getopt::Long;

git-cvsserver.perl

@@ -15,6 +15,7 @@

15 ####

16 ####

18 +use 5.008;

19 use strict;

20 use warnings;

21 use bytes;

git-difftool.perl

@@ -10,6 +10,7 @@

10 #

11 # Any arguments that are unknown to this script are forwarded to 'git diff'.

13 +use 5.008;

14 use strict;

15 use warnings;

16 use Cwd qw(abs_path);

git-relink.perl

+1 -1

@@ -6,7 +6,7 @@

6 #

7 # Scan two git object-trees, and hardlink any common objects between them.

9 -use 5.006;

9 +use 5.008;

10 use strict;

11 use warnings;

12 use Getopt::Long;

git-send-email.perl

@@ -16,6 +16,7 @@

16 # and second line is the subject of the message.

17 #

19 +use 5.008;

20 use strict;

21 use warnings;

22 use Term::ReadLine;

git-svn.perl

@@ -1,6 +1,7 @@

1 #!/usr/bin/env perl

3 # License: GPL v2 or later

4 +use 5.008;

5 use warnings;

6 use strict;

7 use vars qw/ $AUTHOR $VERSION

gitweb/gitweb.perl

@@ -7,6 +7,7 @@

7 #

8 # This program is licensed under the GPLv2

10 +use 5.008;

11 use strict;

12 use warnings;

13 use CGI qw(:standard :escapeHTML -nosticky);

perl/Git.pm

@@ -7,6 +7,7 @@ Git - Perl interface to the Git version control system

8 package Git;

10 +use 5.008;

11 use strict;

t/t7006/test-terminal.perl

@@ -1,4 +1,5 @@

1 #!/usr/bin/perl

2 +use 5.008;

3 use strict;

4 use warnings;

5 use IO::Pty;

t/t9700/test.pl

+1 -1

@@ -1,7 +1,7 @@

1 #!/usr/bin/perl

2 use lib (split(/:/, $ENV{GITPERLLIB}));

4 -use 5.006002;

4 +use 5.008;

5 use warnings;

6 use strict;