submodule--helper: fix bad config API usage
Fix bad config API usage added in a452128a36c (submodule--helper: introduce add-config subcommand, 2021-08-06). After git_config_get_string() returns successfully we know the "char **dest" will be non-NULL. A coccinelle patch that transforms this turns up a couple of other such issues, one in fetch-pack.c, and another in upload-pack.c: @@ identifier F =~ "^(repo|git)_config_get_string(_tmp)?$"; identifier V; @@ !F(..., &V) - && (V) But let's focus narrowly on submodule--helper for now, we can fix those some other time. Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com> Reviewed-by: Glen Choo <chooglen@google.com> Signed-off-by: Junio C Hamano <gitster@pobox.com>
Ævar Arnfjörð Bjarmason committed
Sep 1, 2022 at 01:18 UTC
d4a492f4ad0455710a7db8c589f4865810b0d0b7
1 file changed
+1
-1
builtin/submodule--helper.c
+1
-1
@@ -3107,7 +3107,7 @@ static void configure_added_submodule(struct add_data *add_data)
3107
* is_submodule_active(), since that function needs to find
3108
* out the value of "submodule.active" again anyway.
3109
*/
3110
- if (!git_config_get_string("submodule.active", &val) && val) {
3110
+ if (!git_config_get_string("submodule.active", &val)) {
3111
/*
3112
* If the submodule being added isn't already covered by the
3113
* current configured pathspec, set the submodule's active flag