Makefile: fix misdirected redirections
In general "echo 2>&1 $msg" to redirect a possible error message that comes from 'echo' itself into the same standard output stream $msg is getting written to does not make any sense; it is not like we are expecting to see any errors out of 'echo' in these statements, and even if it were the case, there is no reason to prevent the error messages from being sent to the standard error stream. These are clearly meant to send the argument given to echo to the standard error stream as error messages. Correctly redirect by saying "send what is written to the standard output to the standard error", i.e. "1>&2" aka ">&2". Signed-off-by: Junio C Hamano <gitster@pobox.com>
Junio C Hamano committed
Apr 5, 2016 at 00:02 UTC
d55de70a1edf885fd0c45c9e20a3a00c3f886607
1 file changed
+2
-2
Makefile
+2
-2
@@ -2211,10 +2211,10 @@ sparse: $(SP_OBJ)
2211
check: common-cmds.h
2212
@if sparse; \
2213
then \
2214
- echo 2>&1 "Use 'make sparse' instead"; \
2214
+ echo >&2 "Use 'make sparse' instead"; \
2215
$(MAKE) --no-print-directory sparse; \
2216
else \
2217
- echo 2>&1 "Did you mean 'make test'?"; \
2217
+ echo >&2 "Did you mean 'make test'?"; \
2218
exit 1; \
2219
fi
2220