git-compat-util: add xstrdup_or_null helper
It's a common idiom to duplicate a string if it is non-NULL, or pass a literal NULL through. This is already a one-liner in C, but you do have to repeat the name of the string twice. So if there's a function call, you must write: const char *x = some_fun(...); return x ? xstrdup(x) : NULL; instead of (with this patch) just: return xstrdup_or_null(some_fun(...)); Signed-off-by: Jeff King <peff@peff.net> Signed-off-by: Junio C Hamano <gitster@pobox.com>
Jeff King committed
Jan 12, 2015 at 20:57 UTC
d64ea0f83bd7e676778f833c57f969a94518a28d
1 file changed
+5
git-compat-util.h
+5
@@ -629,6 +629,11 @@ extern char *xgetcwd(void);
629
630
#define REALLOC_ARRAY(x, alloc) (x) = xrealloc((x), (alloc) * sizeof(*(x)))
631
632
+static inline char *xstrdup_or_null(const char *str)
633
+{
634
+ return str ? xstrdup(str) : NULL;
635
+}
636
+
637
static inline size_t xsize_t(off_t len)
638
{
639
if (len > (size_t) len)