config.mak.dev: enable `-Wwrite-strings` warning
Writing to string constants is undefined behaviour and must be avoided in C. Even so, the compiler does not help us with this by default because those constants are not in fact marked as `const`. This makes it rather easy to accidentally assign a constant to a non-const variable or field and then later on try to either free it or write to it. Enable `-Wwrite-strings` to catch such mistakes. With this warning enabled, the type of string constants is changed to `const char[]` and will thus cause compiler warnings when being assigned to non-const fields and variables. Signed-off-by: Patrick Steinhardt <ps@pks.im> Signed-off-by: Junio C Hamano <gitster@pobox.com>
Patrick Steinhardt committed
Jun 7, 2024 at 08:39 UTC
d66fe0726bfb3fb1e3665f7e64b160440007d98e
1 file changed
+1
config.mak.dev
+1
@@ -37,6 +37,7 @@ DEVELOPER_CFLAGS += -Wpointer-arith
37
DEVELOPER_CFLAGS += -Wstrict-prototypes
38
DEVELOPER_CFLAGS += -Wunused
39
DEVELOPER_CFLAGS += -Wvla
40
+DEVELOPER_CFLAGS += -Wwrite-strings
41
DEVELOPER_CFLAGS += -fno-common
42
43
ifneq ($(filter clang4,$(COMPILER_FEATURES)),)