bisect: clean flags after checking merge bases
Unless there is a good reason to belieave that a particular invocation of a get_merge_bases*() is the last one that cares about the object flags the computation of merge bases leaves on the objects, the "cleanup" parameter should always be true, and I do not think there is one in this codepath. Found by code inspection. Signed-off-by: Junio C Hamano <gitster@pobox.com>
Junio C Hamano committed
Oct 30, 2014 at 12:01 UTC
d76c9e95b435b660f8f1b3e01d3c2f934e2ec441
1 file changed
+1
-1
bisect.c
+1
-1
@@ -776,7 +776,7 @@ static void check_merge_bases(int no_checkout)
776
int rev_nr;
777
struct commit **rev = get_bad_and_good_commits(&rev_nr);
778
779
- result = get_merge_bases_many(rev[0], rev_nr - 1, rev + 1, 0);
779
+ result = get_merge_bases_many(rev[0], rev_nr - 1, rev + 1, 1);
780
781
for (; result; result = result->next) {
782
const unsigned char *mb = result->item->object.sha1;