verify_signed_buffer: prefer close_tempfile() to close()

We do a manual close() on the descriptor provided to us by mks_tempfile. But this runs contrary to the advice in tempfile.h, which notes that you should always use close_tempfile(). Otherwise the descriptor may be reused without the tempfile object knowing it, and the later call to delete_tempfile() could close a random descriptor. Signed-off-by: Jeff King <peff@peff.net> Signed-off-by: Junio C Hamano <gitster@pobox.com>

Jeff King committed Sep 5, 2017 at 08:14 UTC d88ef6605120fd75be38376ba147623cf427bf73
1 file changed +1 -1
gpg-interface.c
+1 -1
@@ -215,7 +215,7 @@ int verify_signed_buffer(const char *payload, size_t payload_size,
215 delete_tempfile(&temp);
216 return -1;
217 }
218 - close(fd);
218 + close_tempfile(&temp);
219
220 argv_array_pushl(&gpg.args,
221 gpg_program,