rev-parse test: use test_must_fail, not "if <command>; then false; fi"
This way, if rev-parse segfaults then the test will fail instead of treating it the same way as a controlled failure. Signed-off-by: Felipe Contreras <felipe.contreras@gmail.com> Signed-off-by: Jonathan Nieder <jrnieder@gmail.com> Signed-off-by: Junio C Hamano <gitster@pobox.com>
Felipe Contreras committed
Sep 3, 2013 at 10:06 UTC
d8f7681337dd0c7944ba2293a72952110977077d
1 file changed
+2
-2
t/t6101-rev-parse-parents.sh
+2
-2
@@ -26,7 +26,7 @@ test_expect_success 'start^0' '
26
'
27
28
test_expect_success 'start^1 not valid' '
29
- if git rev-parse --verify start^1; then false; else :; fi
29
+ test_must_fail git rev-parse --verify start^1
30
'
31
32
test_expect_success 'second^1 = second^' '
@@ -50,7 +50,7 @@ test_expect_success 'final^1^2 != final^1^1' '
50
'
51
52
test_expect_success 'final^1^3 not valid' '
53
- if git rev-parse --verify final^1^3; then false; else :; fi
53
+ test_must_fail git rev-parse --verify final^1^3
54
'
55
56
test_expect_success '--verify start2^1' '