rev-list: drop unused void pointer from finish_commit()
Our finish_commit() function used to be passed directly to the revision machinery as a callback. But after 989937221a (rev-list: fix --verify-objects --quiet becoming --objects, 2012-02-28), it is used only as a helper in show_commit(). It doesn't use its void "data" parameter, and we no longer have to conform to the callback interface. Let's drop it. Signed-off-by: Jeff King <peff@peff.net> Signed-off-by: Junio C Hamano <gitster@pobox.com>
Jeff King committed
May 9, 2019 at 17:32 UTC
d92349dd5541ea2d54ec500e204372c93ee89d28
1 file changed
+5
-5
builtin/rev-list.c
+5
-5
@@ -77,7 +77,7 @@ static enum missing_action arg_missing_action;
77
78
#define DEFAULT_OIDSET_SIZE (16*1024)
79
80
-static void finish_commit(struct commit *commit, void *data);
80
+static void finish_commit(struct commit *commit);
81
static void show_commit(struct commit *commit, void *data)
82
{
83
struct rev_list_info *info = data;
@@ -86,7 +86,7 @@ static void show_commit(struct commit *commit, void *data)
86
display_progress(progress, ++progress_counter);
87
88
if (info->flags & REV_LIST_QUIET) {
89
- finish_commit(commit, data);
89
+ finish_commit(commit);
90
return;
91
}
92
@@ -99,7 +99,7 @@ static void show_commit(struct commit *commit, void *data)
99
revs->count_left++;
100
else
101
revs->count_right++;
102
- finish_commit(commit, data);
102
+ finish_commit(commit);
103
return;
104
}
105
@@ -188,10 +188,10 @@ static void show_commit(struct commit *commit, void *data)
188
putchar('\n');
189
}
190
maybe_flush_or_die(stdout, "stdout");
191
- finish_commit(commit, data);
191
+ finish_commit(commit);
192
}
193
194
-static void finish_commit(struct commit *commit, void *data)
194
+static void finish_commit(struct commit *commit)
195
{
196
if (commit->parents) {
197
free_commit_list(commit->parents);