@matheusbsbs / matheus-bagliano / commits / d9244ecf4f

Windows: do not treat a path with backslashes as a remote's nick name

On Windows, the remote repository name in, e.g., `git fetch foo\bar` is clearly not a nickname for a configured remote repository. However, the function valid_remote_nick() does not account for backslashes. Use is_dir_sep() to check for both slashes and backslashes on Windows. This was discovered while playing with Duy's patches that warn after fopen() failures. The functions that read the branches and remotes files are protected by a valid_remote_nick() check. Without this change, a Windows style absolute path is incorrectly regarded as nickname and is concatenated to a prefix and used with fopen(). This triggers warnings because a colon in a path name is not allowed: C:\Temp\gittest>git fetch C:\Temp\gittest warning: unable to access '.git/remotes/C:\Temp\gittest': Invalid argument warning: unable to access '.git/branches/C:\Temp\gittest': Invalid argument From C:\Temp\gittest * branch HEAD -> FETCH_HEAD Signed-off-by: Johannes Sixt <j6t@kdbg.org> Signed-off-by: Junio C Hamano <gitster@pobox.com>

Johannes Sixt committed May 25, 2017 at 14:00 UTC d9244ecf4f109030e61b8fd52a799789133e2199

1 file changed +6 -1

remote.c

+6 -1

@@ -645,7 +645,12 @@ static int valid_remote_nick(const char *name)

645 {

646 if (!name[0] || is_dot_or_dotdot(name))

647 return 0;

648 - return !strchr(name, '/'); /* no slash */

648 +

649 + /* remote nicknames cannot contain slashes */

650 + while (*name)

651 + if (is_dir_sep(*name++))

652 + return 0;

653 + return 1;

654 }

655

656 const char *remote_for_branch(struct branch *branch, int *explicit)