Properly handle '0' filenames in import-tars
Randal L. Schwartz pointed out multiple times that we should be testing the length of the name string here, not if it is "true". The problem is the string '0' is actually false in Perl when we try to evaluate it in this context, as '0' is 0 numerically and the number 0 is treated as a false value. This would cause us to break out of the import loop early if anyone had a file or directory named "0". Signed-off-by: Shawn O. Pearce <spearce@spearce.org>
Shawn O. Pearce committed
May 7, 2007 at 21:13 UTC
d966e6aa66d397908b4fbf69cef2e2da88737321
1 file changed
+1
-1
contrib/fast-import/import-tars.perl
+1
-1
@@ -51,7 +51,7 @@ foreach my $tar_file (@ARGV)
51
$prefix) = unpack 'Z100 Z8 Z8 Z8 Z12 Z12
52
Z8 Z1 Z100 Z6
53
Z2 Z32 Z32 Z8 Z8 Z*', $_;
54
- last unless $name;
54
+ last unless length($name);
55
if ($name eq '././@LongLink') {
56
# GNU tar extension
57
if (read(I, $_, 512) != 512) {