replace xstrdup(git_path(...)) with git_pathdup(...)
It's more efficient to use git_pathdup(), as it skips an extra copy of the path. And by removing some calls to git_path(), it makes it easier to audit for dangerous uses. Signed-off-by: Jeff King <peff@peff.net> Signed-off-by: Junio C Hamano <gitster@pobox.com>
Jeff King committed
Apr 20, 2017 at 17:09 UTC
d9c69644b27eb59fe16c1931580e6fce4abbdc65
2 files changed
+4
-3
builtin/config.c
+3
-2
@@ -599,8 +599,9 @@ int cmd_config(int argc, const char **argv, const char *prefix)
599
if (given_config_source.blob)
600
die("editing blobs is not supported");
601
git_config(git_default_config, NULL);
602
- config_file = xstrdup(given_config_source.file ?
603
- given_config_source.file : git_path("config"));
602
+ config_file = given_config_source.file ?
603
+ xstrdup(given_config_source.file) :
604
+ git_pathdup("config");
605
if (use_global_config) {
606
int fd = open(config_file, O_CREAT | O_EXCL | O_WRONLY, 0666);
607
if (fd >= 0) {
fast-import.c
+1
-1
@@ -3203,7 +3203,7 @@ static char* make_fast_import_path(const char *path)
3203
{
3204
if (!relative_marks_paths || is_absolute_path(path))
3205
return xstrdup(path);
3206
- return xstrdup(git_path("info/fast-import/%s", path));
3206
+ return git_pathdup("info/fast-import/%s", path);
3207
}
3208
3209
static void option_import_marks(const char *marks,