@matheusbsbs / matheus-bagliano / commits / d9e2e12700
Fork 0

git-svnimport.perl: fix for 'arg list too long...'

This fixes 'arg list too long..' problem with git-ls-files. Note that second arg list separation loop (with 'git-update-index') is needed since git-ls-files arguments can be directories. Signed-off-by: Sasha Khapyorsky <sashak@voltaire.com> Signed-off-by: Junio C Hamano <junkio@cox.net>

Sasha Khapyorsky committed Feb 1, 2006 at 17:53 UTC d9e2e12700e403ae5fc11193dd6e91546abd5809
1 file changed +16 -9
git-svnimport.perl
+16 -9
@@ -546,23 +546,30 @@ sub commit {
546 }
547 }
548
549 - if(@old) {
550 - open my $F, "-|", "git-ls-files", "-z", @old or die $!;
551 - @old = ();
549 + while(@old) {
550 + my @o1;
551 + if(@old > 55) {
552 + @o1 = splice(@old,0,50);
553 + } else {
554 + @o1 = @old;
555 + @old = ();
556 + }
557 + open my $F, "-|", "git-ls-files", "-z", @o1 or die $!;
558 + @o1 = ();
559 local $/ = "\0";
560 while(<$F>) {
561 chomp;
555 - push(@old,$_);
562 + push(@o1,$_);
563 }
564 close($F);
565
559 - while(@old) {
566 + while(@o1) {
567 my @o2;
561 - if(@old > 55) {
562 - @o2 = splice(@old,0,50);
568 + if(@o1 > 55) {
569 + @o2 = splice(@o1,0,50);
570 } else {
564 - @o2 = @old;
565 - @old = ();
571 + @o2 = @o1;
572 + @o1 = ();
573 }
574 system("git-update-index","--force-remove","--",@o2);
575 die "Cannot remove files: $?\n" if $?;