pack-bitmap: don't perform unaligned memory access
The preceding bitmap entries have a 1-byte XOR-offset and 1-byte flags, so their size is not a multiple of 4. Thus the name-hash cache is only guaranteed to be 2-byte aligned and so we must use get_be32 rather than indexing the array directly. Signed-off-by: James Clarke <jrtc27@jrtc27.com> Signed-off-by: Junio C Hamano <gitster@pobox.com>
James Clarke committed
Jun 26, 2017 at 16:16 UTC
da41c942b307e0beab1fc5800a42b0c495f54ff6
1 file changed
+1
-1
pack-bitmap.c
+1
-1
@@ -627,7 +627,7 @@ static void show_objects_for_type(
627
sha1 = nth_packed_object_sha1(bitmap_git.pack, entry->nr);
628
629
if (bitmap_git.hashes)
630
- hash = ntohl(bitmap_git.hashes[entry->nr]);
630
+ hash = get_be32(bitmap_git.hashes + entry->nr);
631
632
show_reach(sha1, object_type, 0, hash, bitmap_git.pack, entry->offset);
633
}