setup_bare_git_dir(): help static analysis
Coverity reported a memory leak in this function. However, it can only be called once, as setup_git_directory() changes global state and hence is not reentrant. Mark the variable as static to indicate that this is a singleton. Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de> Signed-off-by: Junio C Hamano <gitster@pobox.com>
Johannes Schindelin committed
May 4, 2017 at 15:56 UTC
da6f847559d8794f25da9f7c090929baebce7751
1 file changed
+1
-1
setup.c
+1
-1
@@ -748,7 +748,7 @@ static const char *setup_bare_git_dir(struct strbuf *cwd, int offset,
748
749
/* --work-tree is set without --git-dir; use discovered one */
750
if (getenv(GIT_WORK_TREE_ENVIRONMENT) || git_work_tree_cfg) {
751
- const char *gitdir;
751
+ static const char *gitdir;
752
753
gitdir = offset == cwd->len ? "." : xmemdupz(cwd->buf, offset);
754
if (chdir(cwd->buf))