@matheusbsbs / matheus-bagliano / commits / db170e1826

completion: make sed command that generates config-list.h portable.

The OpenBSD 'sed' command does not support '\n' to represent newlines in sed expressions. This leads to the follow compiler error: In file included from builtin/help.c:15: ./config-list.h:282:18: error: use of undeclared identifier 'n' "gitcvs.dbUser",n "gitcvs.dbPass", ^ 1 error generated. gmake: *** [Makefile:2821: builtin/help.o] Error 1 We can fix this by documenting related configuration variables one-per-line instead of listing them separated by commas. This allows us to remove the unportable part of the sed expression in generate-configlist.sh. Signed-off-by: Collin Funk <collin.funk1@gmail.com> Reviewed-by: Jacob Keller <jacob.keller@gmail.com> Signed-off-by: Junio C Hamano <gitster@pobox.com>

Collin Funk committed Jun 2, 2025 at 15:31 UTC db170e18262ed10e5e9b7f3cbca6a0ac43267b20
3 files changed +4 -3
Documentation/config/gitcvs.adoc
+2 -1
@@ -47,7 +47,8 @@ gitcvs.dbDriver::
47 May not contain double colons (`:`). Default: 'SQLite'.
48 See linkgit:git-cvsserver[1].
49
50 -gitcvs.dbUser, gitcvs.dbPass::
50 +gitcvs.dbUser::
51 +gitcvs.dbPass::
52 Database user and password. Only useful if setting `gitcvs.dbDriver`,
53 since SQLite has no concept of database users and/or passwords.
54 'gitcvs.dbUser' supports variable substitution (see
Documentation/config/http.adoc
+2 -1
@@ -289,7 +289,8 @@ for most push problems, but can increase memory consumption
289 significantly since the entire buffer is allocated even for small
290 pushes.
291
292 -http.lowSpeedLimit, http.lowSpeedTime::
292 +http.lowSpeedLimit::
293 +http.lowSpeedTime::
294 If the HTTP transfer speed, in bytes per second, is less than
295 'http.lowSpeedLimit' for longer than 'http.lowSpeedTime' seconds,
296 the transfer is aborted.
generate-configlist.sh
-1
@@ -19,7 +19,6 @@ EOF
19 s/::$//;
20 s/`//g;
21 s/^.*$/ "&",/;
22 - s/, */",\n "/g;
22 p;};
23 d' \
24 "$SOURCE_DIR"/Documentation/*config.adoc \