push: do not pretend to return `int` from `die_push_simple()`
This function is marked as `NORETURN`, and it indeed does not want to return anything. So let's not declare it with the return type `int`. This fixes the following warning when building with MSVC: C4646: function declared with 'noreturn' has non-void return type Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de> Signed-off-by: Junio C Hamano <gitster@pobox.com>
Johannes Schindelin committed
Sep 30, 2019 at 02:55 UTC
dbcd970c27ba42ab09073211f858b1a89c7f8300
1 file changed
+2
-2
builtin/push.c
+2
-2
@@ -143,8 +143,8 @@ static int push_url_of_remote(struct remote *remote, const char ***url_p)
143
return remote->url_nr;
144
}
145
146
-static NORETURN int die_push_simple(struct branch *branch,
147
- struct remote *remote)
146
+static NORETURN void die_push_simple(struct branch *branch,
147
+ struct remote *remote)
148
{
149
/*
150
* There's no point in using shorten_unambiguous_ref here,