@matheusbsbs / matheus-bagliano / commits / dcbeac48a7
Fork 0

checkout, commit: remove confusing assignments to rev.abbrev

Since they do not precede setup_revisions, these assignments of 0 to rev.abbrev have no effect. v1.7.1.1~17^2~3 (2010-05-03) taught the log --format=%h machinery to respect --abbrev instead of always abbreviating, so we have to pay attention to the abbrev setting now. Helped-by: Junio C Hamano <gitster@pobox.com> Signed-off-by: Jonathan Nieder <jrnieder@gmail.com> Signed-off-by: Junio C Hamano <gitster@pobox.com>

Jonathan Nieder committed Jul 27, 2010 at 13:37 UTC dcbeac48a7e61154c53ae800ea224607c1f7d52a
2 files changed -2
builtin/checkout.c
-1
@@ -279,7 +279,6 @@ static void show_local_changes(struct object *head)
279 struct rev_info rev;
280 /* I think we want full paths, even if we're in a subdirectory. */
281 init_revisions(&rev, NULL);
282 - rev.abbrev = 0;
282 rev.diffopt.output_format |= DIFF_FORMAT_NAME_STATUS;
283 if (diff_setup_done(&rev.diffopt) < 0)
284 die("diff_setup_done failed");
builtin/commit.c
-1
@@ -1163,7 +1163,6 @@ static void print_summary(const char *prefix, const unsigned char *sha1)
1163 init_revisions(&rev, prefix);
1164 setup_revisions(0, NULL, &rev, NULL);
1165
1166 - rev.abbrev = 0;
1166 rev.diff = 1;
1167 rev.diffopt.output_format =
1168 DIFF_FORMAT_SHORTSTAT | DIFF_FORMAT_SUMMARY;