Git.pm: add comment pointing to t9000
parse_mailboxes should probably eventually be completely equivalent to Mail::Address, and if this happens we can drop the Mail::Address dependency. Add a comment in the code reminding the current state of the code, and point to the corresponding failing test to help future contributors to get it right. Signed-off-by: Matthieu Moy <Matthieu.Moy@imag.fr> Signed-off-by: Junio C Hamano <gitster@pobox.com>
Matthieu Moy committed
Oct 21, 2016 at 11:20 UTC
dcfafc5214e6af277aa8565af4f63b20046d65bf
1 file changed
+2
perl/Git.pm
+2
@@ -870,6 +870,8 @@ Return an array of mailboxes extracted from a string.
870
871
=cut
872
873
+# Very close to Mail::Address's parser, but we still have minor
874
+# differences in some cases (see t9000 for examples).
875
sub parse_mailboxes {
876
my $re_comment = qr/\((?:[^)]*)\)/;
877
my $re_quote = qr/"(?:[^\"\\]|\\.)*"/;