CodingGuidelines: once it is in, it is not worth the code churn
Signed-off-by: Junio C Hamano <gitster@pobox.com>
Junio C Hamano committed
Apr 30, 2014 at 14:23 UTC
dd30800bcd236233c82da80bba0d00956a246260
1 file changed
+8
Documentation/CodingGuidelines
+8
@@ -18,6 +18,14 @@ code. For Git in general, three rough rules are:
18
judgement call, the decision based more on real world
19
constraints people face than what the paper standard says.
20
21
+ - Fixing style violations while working on a real change as a
22
+ preparatory clean-up step is good, but otherwise avoid useless code
23
+ churn for the sake of conforming to the style.
24
+
25
+ "Once it _is_ in the tree, it's not really worth the patch noise to
26
+ go and fix it up."
27
+ Cf. http://article.gmane.org/gmane.linux.kernel/943020
28
+
29
Make your code readable and sensible, and don't try to be clever.
30
31
As for more concrete guidelines, just imitate the existing code