refs DWIMmery: use the same rule for both "git fetch" and others

"git log frotz" can DWIM to "refs/remotes/frotz/HEAD", but in the remote access context, "git fetch frotz" to fetch what the other side happened to have fetched from what it calls 'frotz' (which may not have any relation to what we consider is 'frotz') the last time would not make much sense, so the fetch rules table did not include "refs/remotes/%.*s/HEAD". When the user really wants to, "git fetch $there remotes/frotz/HEAD" would let her do so anyway, so this is not about safety or security; it merely is about confusion avoidance and discouraging meaningless usage. Specifically, it is _not_ about ambiguity avoidance. A name that would become ambiguous if we use the same rules table for both fetch and local rev-parse would be ambiguous locally at the remote side. So for the same reason as we added rule to allow "git fetch $there v1.0" instead of "git fetch $there tags/v1.0" in the previous commit, here is a bit longer rope for the users, which incidentally simplifies our code. Signed-off-by: Junio C Hamano <gitster@pobox.com>

Junio C Hamano committed Nov 4, 2011 at 14:14 UTC dd621df9cde83fc08f9d3924b793b989b8f8a313
3 files changed +3 -12
cache.h
+1 -1
@@ -873,7 +873,7 @@ extern int get_sha1_mb(const char *str, unsigned char *sha1);
873
874 extern int refname_match(const char *abbrev_name, const char *full_name, const char **rules);
875 extern const char *ref_rev_parse_rules[];
876 -extern const char *ref_fetch_rules[];
876 +#define ref_fetch_rules ref_rev_parse_rules
877
878 extern int create_symref(const char *ref, const char *refs_heads_master, const char *logmsg);
879 extern int validate_headref(const char *ref);
refs.c
-8
@@ -995,14 +995,6 @@ const char *ref_rev_parse_rules[] = {
995 NULL
996 };
997
998 -const char *ref_fetch_rules[] = {
999 - "%.*s",
1000 - "refs/%.*s",
1001 - "refs/tags/%.*s",
1002 - "refs/heads/%.*s",
1003 - NULL
1004 -};
1005 -
998 int refname_match(const char *abbrev_name, const char *full_name, const char **rules)
999 {
1000 const char **p;
t/t5510-fetch.sh
+2 -3
@@ -116,7 +116,7 @@ test_expect_success 'fetch must not resolve short tag name' '
116
117 '
118
119 -test_expect_success 'fetch must not resolve short remote name' '
119 +test_expect_success 'fetch can now resolve short remote name' '
120
121 cd "$D" &&
122 git update-ref refs/remotes/six/HEAD HEAD &&
@@ -125,8 +125,7 @@ test_expect_success 'fetch must not resolve short remote name' '
125 cd six &&
126 git init &&
127
128 - test_must_fail git fetch .. six:six
129 -
128 + git fetch .. six:six
129 '
130
131 test_expect_success 'create bundle 1' '