t0300-credentials.sh: use the $( ... ) construct for command substitution
The Git CodingGuidelines prefer the $(...) construct for command substitution instead of using the backquotes `...`. The backquoted form is the traditional method for command substitution, and is supported by POSIX. However, all but the simplest uses become complicated quickly. In particular, embedded command substitutions and/or the use of double quotes require careful escaping with the backslash character. The patch was generated by: for _f in $(find . -name "*.sh") do sed -i 's@`\(.*\)`@$(\1)@g' ${_f} done and then carefully proof-read. Signed-off-by: Elia Pinto <gitter.spiros@gmail.com> Reviewed-by: Matthieu Moy <Matthieu.Moy@imag.fr> Signed-off-by: Junio C Hamano <gitster@pobox.com>
Elia Pinto committed
Apr 28, 2014 at 05:57 UTC
dd64267fe2151b1ea3f19b5745d0fa8321995381
1 file changed
+1
-1
t/t0300-credentials.sh
+1
-1
@@ -6,7 +6,7 @@ test_description='basic credential helper tests'
6
7
test_expect_success 'setup helper scripts' '
8
cat >dump <<-\EOF &&
9
- whoami=`echo $0 | sed s/.*git-credential-//`
9
+ whoami=$(echo $0 | sed s/.*git-credential-//)
10
echo >&2 "$whoami: $*"
11
OIFS=$IFS
12
IFS==