@matheusbsbs / matheus-bagliano / commits / de89f0b25a

remote-curl: die directly with http error messages

When we encounter an unknown http error (e.g., a 403), we hand the error code to http_error, which then prints it with error(). After that we die with the redundant message "HTTP request failed". Instead, let's just drop http_error entirely, which does nothing but pass arguments to error(), and instead die directly with a useful message. So before: $ git clone https://example.com/repo.git Cloning into 'repo'... error: unable to access 'https://example.com/repo.git': The requested URL returned error: 403 Forbidden fatal: HTTP request failed and after: $ git clone https://example.com/repo.git Cloning into 'repo'... fatal: unable to access 'https://example.com/repo.git': The requested URL returned error: 403 Forbidden Signed-off-by: Jeff King <peff@peff.net> Signed-off-by: Junio C Hamano <gitster@pobox.com>

Jeff King committed Apr 5, 2013 at 18:22 UTC de89f0b25a42238948787421c0253228c006f7fa

1 file changed +1 -2

remote-curl.c

+1 -2

@@ -216,8 +216,7 @@ static struct discovery* discover_refs(const char *service, int for_push)

216 die("Authentication failed for '%s'", url);

217 default:

218 show_http_message(&type, &buffer);

219 - http_error(url);

220 - die("HTTP request failed");

219 + die("unable to access '%s': %s", url, curl_errorstr);

220 }

221

222 last= xcalloc(1, sizeof(*last_discovery));