add--interactive: fix external command invocation on Windows
Back in 21e9757e (Hack git-add--interactive to make it work with ActiveState Perl, 2007-08-01), the invocation of external commands was changed to use qx{} on Windows. The rationale was that the command interpreter on Windows is not a POSIX shell, but rather Windows's CMD. That patch was wrong to include 'msys' in the check whether to use qx{} or not: 'msys' identifies MSYS perl as shipped with Git for Windows, which does not need the special treatment; qx{} should be used only with ActiveState perl, which is identified by 'MSWin32'. Signed-off-by: Johannes Sixt <j6t@kdbg.org> Signed-off-by: Junio C Hamano <gitster@pobox.com>
Johannes Sixt committed
Sep 4, 2013 at 09:24 UTC
df17e77c0aacca35eaaac885fe70d97654c07d62
1 file changed
+1
-1
git-add--interactive.perl
+1
-1
@@ -169,7 +169,7 @@ my %patch_modes = (
169
my %patch_mode_flavour = %{$patch_modes{stage}};
170
171
sub run_cmd_pipe {
172
- if ($^O eq 'MSWin32' || $^O eq 'msys') {
172
+ if ($^O eq 'MSWin32') {
173
my @invalid = grep {m/[":*]/} @_;
174
die "$^O does not support: @invalid\n" if @invalid;
175
my @args = map { m/ /o ? "\"$_\"": $_ } @_;