Revert "setup: set env $GIT_WORK_TREE when work tree is set, like $GIT_DIR"

This reverts d95138e6 (setup: set env $GIT_WORK_TREE when work tree is set, like $GIT_DIR, 2015-06-26). It has caused three regression reports so far. http://article.gmane.org/gmane.comp.version-control.git/281608 http://article.gmane.org/gmane.comp.version-control.git/281979 http://article.gmane.org/gmane.comp.version-control.git/282691 All of them are about spawning git subprocesses, where the new presence of GIT_WORK_TREE either changes command behaviour (git-init or git-clone), or how repo/worktree is detected (from aliases), with or without $GIT_DIR. The original bug will be re-fixed another way. Signed-off-by: Nguyễn Thái Ngọc Duy <pclouds@gmail.com> Signed-off-by: Junio C Hamano <gitster@pobox.com>

Nguyễn Thái Ngọc Duy committed Dec 21, 2015 at 17:22 UTC df1e6ea87a58fc8d029efb3041d851f7d6653a1d
2 files changed +1 -3
environment.c
-2
@@ -211,8 +211,6 @@ void set_git_work_tree(const char *new_work_tree)
211 }
212 git_work_tree_initialized = 1;
213 work_tree = xstrdup(real_path(new_work_tree));
214 - if (setenv(GIT_WORK_TREE_ENVIRONMENT, work_tree, 1))
215 - die("could not set GIT_WORK_TREE to '%s'", work_tree);
214 }
215
216 const char *get_git_work_tree(void)
t/t0002-gitfile.sh
+1 -1
@@ -99,7 +99,7 @@ test_expect_success 'check rev-list' '
99 test "$SHA" = "$(git rev-list HEAD)"
100 '
101
102 -test_expect_success 'setup_git_dir twice in subdir' '
102 +test_expect_failure 'setup_git_dir twice in subdir' '
103 git init sgd &&
104 (
105 cd sgd &&