@matheusbsbs / matheus-bagliano / commits / dfa4647812
Fork 0

fetch/clone: mark messages from remote side stand out.

When dealing with a corrupt or out of sync remote repository, the user often gets error messages like this: error: refs/heads/devel does not point to a valid commit object! which leaves the user wondering if the breakage is on the local end or on the remote end. This is unnecessarily alarming. This patch changes the way we display messages received from the remote side over the git protocol sideband (i.e. stderr stream of the remote process). It shows them with blue background with white letters, but this presentation is subject to proposals of better ways from the list. The problem was pointed out by Andrew Morton. Signed-off-by: Junio C Hamano <junkio@cox.net>

Junio C Hamano committed Aug 1, 2006 at 01:34 UTC dfa464781286e3a6fb1d56a834bb15ac7fc4fb16
1 file changed +3
fetch-clone.c
+3
@@ -133,7 +133,10 @@ static pid_t setup_sideband(int sideband, const char *me, int fd[2], int xd[2])
133 fprintf(stderr, "\n");
134 exit(1);
135 case 2:
136 + /* color sideband */
137 + safe_write(2, "\033[44;37;1m", 10);
138 safe_write(2, buf+1, len);
139 + safe_write(2, "\033[m", 3);
140 continue;
141 case 1:
142 safe_write(fd[1], buf+1, len);