ref-filter: drop unused buf/sz pairs
The grab_tag_values() and grab_commit_values() functions take both the "struct object" as well as the buf/sz pair for the actual object bytes. However, neither function uses the latter, as they pull the data directly from the parsed object struct. Let's get rid of these misleading parameters. Signed-off-by: Jeff King <peff@peff.net> Signed-off-by: Junio C Hamano <gitster@pobox.com>
Jeff King committed
Feb 14, 2019 at 00:50 UTC
e0329199a7b40372dec50a1bc1c497f5fbb2ddbc
1 file changed
+4
-4
ref-filter.c
+4
-4
@@ -913,7 +913,7 @@ static void grab_common_values(struct atom_value *val, int deref, struct expand_
913
}
914
915
/* See grab_values */
916
-static void grab_tag_values(struct atom_value *val, int deref, struct object *obj, void *buf, unsigned long sz)
916
+static void grab_tag_values(struct atom_value *val, int deref, struct object *obj)
917
{
918
int i;
919
struct tag *tag = (struct tag *) obj;
@@ -935,7 +935,7 @@ static void grab_tag_values(struct atom_value *val, int deref, struct object *ob
935
}
936
937
/* See grab_values */
938
-static void grab_commit_values(struct atom_value *val, int deref, struct object *obj, void *buf, unsigned long sz)
938
+static void grab_commit_values(struct atom_value *val, int deref, struct object *obj)
939
{
940
int i;
941
struct commit *commit = (struct commit *) obj;
@@ -1269,12 +1269,12 @@ static void grab_values(struct atom_value *val, int deref, struct object *obj, v
1269
{
1270
switch (obj->type) {
1271
case OBJ_TAG:
1272
- grab_tag_values(val, deref, obj, buf, sz);
1272
+ grab_tag_values(val, deref, obj);
1273
grab_sub_body_contents(val, deref, obj, buf, sz);
1274
grab_person("tagger", val, deref, obj, buf, sz);
1275
break;
1276
case OBJ_COMMIT:
1277
- grab_commit_values(val, deref, obj, buf, sz);
1277
+ grab_commit_values(val, deref, obj);
1278
grab_sub_body_contents(val, deref, obj, buf, sz);
1279
grab_person("author", val, deref, obj, buf, sz);
1280
grab_person("committer", val, deref, obj, buf, sz);