reftable/writer: drop static variable used to initialize strbuf
We have a static variable in the reftable writer code that is merely used to initialize the `last_key` of the writer. Convert the code to instead use `strbuf_init()` and drop the variable. Signed-off-by: Patrick Steinhardt <ps@pks.im> Signed-off-by: Junio C Hamano <gitster@pobox.com>
Patrick Steinhardt committed
May 13, 2024 at 10:18 UTC
e0cf3d8f8bc0480e67ac83502c10d6e6c38e1e11
1 file changed
+1
-3
reftable/writer.c
+1
-3
@@ -117,8 +117,6 @@ static void writer_reinit_block_writer(struct reftable_writer *w, uint8_t typ)
117
w->block_writer->restart_interval = w->opts.restart_interval;
118
}
119
120
-static struct strbuf reftable_empty_strbuf = STRBUF_INIT;
121
-
120
struct reftable_writer *
121
reftable_new_writer(ssize_t (*writer_func)(void *, const void *, size_t),
122
int (*flush_func)(void *),
@@ -136,7 +134,7 @@ reftable_new_writer(ssize_t (*writer_func)(void *, const void *, size_t),
134
}
135
136
strbuf_init(&wp->block_writer_data.last_key, 0);
139
- wp->last_key = reftable_empty_strbuf;
137
+ strbuf_init(&wp->last_key, 0);
138
REFTABLE_CALLOC_ARRAY(wp->block, opts.block_size);
139
wp->write = writer_func;
140
wp->write_arg = writer_arg;