t0060: add tests for prefix_path when path begins with work tree
One edge-case that isn't currently checked in the tests is the beginning of the path matching the work tree, despite the target not actually being the work tree, for example: path = /dir/repoa work_tree = /dir/repo should fail since the path is outside the repo. However, if /dir/repoa is in fact a symlink that points to /dir/repo, it should instead succeed. Add two tests covering these cases, since they might be potential regression points. Signed-off-by: Martin Erik Werner <martinerikwerner@gmail.com> Reviewed-by: Duy Nguyen <pclouds@gmail.com> Signed-off-by: Junio C Hamano <gitster@pobox.com>
Martin Erik Werner committed
Feb 4, 2014 at 15:25 UTC
e131daa4c6baa53aba22e5d8bc1defa83b443bf0
1 file changed
+10
t/t0060-path-utils.sh
+10
@@ -201,6 +201,16 @@ test_expect_success 'prefix_path works with only absolute path to work tree' '
201
test_cmp expected actual
202
'
203
204
+test_expect_success 'prefix_path rejects absolute path to dir with same beginning as work tree' '
205
+ test_must_fail test-path-utils prefix_path prefix "$(pwd)a"
206
+'
207
+
208
+test_expect_success SYMLINKS 'prefix_path works with absolute path to a symlink to work tree having same beginning as work tree' '
209
+ git init repo &&
210
+ ln -s repo repolink &&
211
+ test "a" = "$(cd repo && test-path-utils prefix_path prefix "$(pwd)/../repolink/a")"
212
+'
213
+
214
relative_path /foo/a/b/c/ /foo/a/b/ c/
215
relative_path /foo/a/b/c/ /foo/a/b c/
216
relative_path /foo/a//b//c/ ///foo/a/b// c/ POSIX