t/t5506-remote-groups.sh: use the $( ... ) construct for command substitution
The Git CodingGuidelines prefer the $(...) construct for command substitution instead of using the backquotes `...`. The backquoted form is the traditional method for command substitution, and is supported by POSIX. However, all but the simplest uses become complicated quickly. In particular, embedded command substitutions and/or the use of double quotes require careful escaping with the backslash character. The patch was generated by: for _f in $(find . -name "*.sh") do perl -i -pe 'BEGIN{undef $/;} s/`(.+?)`/\$(\1)/smg' "${_f}" done and then carefully proof-read. Signed-off-by: Elia Pinto <gitter.spiros@gmail.com> Signed-off-by: Junio C Hamano <gitster@pobox.com>
Elia Pinto committed
Dec 23, 2015 at 14:45 UTC
e15243cc77a58a3038aac3a1977cc8fe0ab45898
1 file changed
+1
-1
t/t5506-remote-groups.sh
+1
-1
@@ -20,7 +20,7 @@ update_repos() {
20
}
21
22
repo_fetched() {
23
- if test "`git log -1 --pretty=format:%s $1 --`" = "`cat mark`"; then
23
+ if test "$(git log -1 --pretty=format:%s $1 --)" = "$(cat mark)"; then
24
echo >&2 "repo was fetched: $1"
25
return 0
26
fi