ci(github): make Windows test artifacts name unique
If several jobs in the windows-test or vs-test matrices fail, the upload-artifact action in each job tries to upload the test directories of the failed tests as "failed-tests-windows.zip", which fails for all jobs except the one which finishes first with the following error: Error: Failed to CreateArtifact: Received non-retryable error: Failed request: (409) Conflict: an artifact with this name already exists on the workflow run Make the artifacts name unique by using the 'matrix.nr' token, and disambiguate the vs-test artifacts from the windows-test ones. Signed-off-by: Philippe Blain <levraiphilippeblain@gmail.com> Signed-off-by: Junio C Hamano <gitster@pobox.com>
Philippe Blain committed
Mar 10, 2024 at 20:04 UTC
e1aaf309db559fd722185bfdea61d3a31d9bbfd4
1 file changed
+2
-2
.github/workflows/main.yml
+2
-2
@@ -159,7 +159,7 @@ jobs:
159
if: failure() && env.FAILED_TEST_ARTIFACTS != ''
160
uses: actions/upload-artifact@v4
161
with:
162
- name: failed-tests-windows
162
+ name: failed-tests-windows-${{ matrix.nr }}
163
path: ${{env.FAILED_TEST_ARTIFACTS}}
164
vs-build:
165
name: win+VS build
@@ -250,7 +250,7 @@ jobs:
250
if: failure() && env.FAILED_TEST_ARTIFACTS != ''
251
uses: actions/upload-artifact@v4
252
with:
253
- name: failed-tests-windows
253
+ name: failed-tests-windows-vs-${{ matrix.nr }}
254
path: ${{env.FAILED_TEST_ARTIFACTS}}
255
regular:
256
name: ${{matrix.vector.jobname}} (${{matrix.vector.pool}})