@matheusbsbs / matheus-bagliano / commits / e242148012
Fork 0

string-list: add unsorted_string_list_lookup()

Sometimes users need to lookup a string in an unsorted string_list. In that case they should use this function instead of the version for sorted strings. Signed-off-by: Stephen Boyd <bebarino@gmail.com> Signed-off-by: Junio C Hamano <gitster@pobox.com>

Stephen Boyd committed Mar 24, 2010 at 00:16 UTC e242148012196772e3fe2652d538fb923b91ca92
3 files changed +17 -5
Documentation/technical/api-string-list.txt
+5 -1
@@ -104,8 +104,12 @@ write `string_list_insert(...)->util = ...;`.
104 `unsorted_string_list_has_string`::
105
106 It's like `string_list_has_string()` but for unsorted lists.
107 +
108 +`unsorted_string_list_lookup`::
109 +
110 + It's like `string_list_lookup()` but for unsorted lists.
111 +
108 -This function needs to look through all items, as opposed to its
112 +The above two functions need to look through all items, as opposed to their
113 counterpart for sorted lists, which performs a binary search.
114
115 Data structures
string-list.c
+10 -3
@@ -168,12 +168,19 @@ void sort_string_list(struct string_list *list)
168 qsort(list->items, list->nr, sizeof(*list->items), cmp_items);
169 }
170
171 -int unsorted_string_list_has_string(struct string_list *list, const char *string)
171 +struct string_list_item *unsorted_string_list_lookup(struct string_list *list,
172 + const char *string)
173 {
174 int i;
175 for (i = 0; i < list->nr; i++)
176 if (!strcmp(string, list->items[i].string))
176 - return 1;
177 - return 0;
177 + return list->items + i;
178 + return NULL;
179 +}
180 +
181 +int unsorted_string_list_has_string(struct string_list *list,
182 + const char *string)
183 +{
184 + return unsorted_string_list_lookup(list, string) != NULL;
185 }
186
string-list.h
+2 -1
@@ -38,5 +38,6 @@ struct string_list_item *string_list_lookup(const char *string, struct string_li
38 struct string_list_item *string_list_append(const char *string, struct string_list *list);
39 void sort_string_list(struct string_list *list);
40 int unsorted_string_list_has_string(struct string_list *list, const char *string);
41 -
41 +struct string_list_item *unsorted_string_list_lookup(struct string_list *list,
42 + const char *string);
43 #endif /* STRING_LIST_H */