revision: fix leaking bloom filters
The memory allocated by `prepare_to_use_bloom_filter()` is not released by `release_revisions()`, causing a memory leak. Plug it. Signed-off-by: Patrick Steinhardt <ps@pks.im> Signed-off-by: Junio C Hamano <gitster@pobox.com>
Patrick Steinhardt committed
Nov 5, 2024 at 07:16 UTC
e29ff075e082ecdc6ee85baea83d32d4a055d186
2 files changed
+6
revision.c
+5
@@ -3227,6 +3227,11 @@ void release_revisions(struct rev_info *revs)
3227
clear_decoration(&revs->treesame, free);
3228
line_log_free(revs);
3229
oidset_clear(&revs->missing_commits);
3230
+
3231
+ for (int i = 0; i < revs->bloom_keys_nr; i++)
3232
+ clear_bloom_key(&revs->bloom_keys[i]);
3233
+ FREE_AND_NULL(revs->bloom_keys);
3234
+ revs->bloom_keys_nr = 0;
3235
}
3236
3237
static void add_child(struct rev_info *revs, struct commit *parent, struct commit *child)
t/t4216-log-bloom.sh
+1
@@ -4,6 +4,7 @@ test_description='git log for a path with Bloom filters'
4
GIT_TEST_DEFAULT_INITIAL_BRANCH_NAME=main
5
export GIT_TEST_DEFAULT_INITIAL_BRANCH_NAME
6
7
+TEST_PASSES_SANITIZE_LEAK=true
8
. ./test-lib.sh
9
. "$TEST_DIRECTORY"/lib-chunk.sh
10