t5551: make the test for extra HTTP headers more robust
To test that extra HTTP headers are passed correctly, t5551 verifies that a fetch succeeds when two required headers are passed, and that the fetch does not succeed when those headers are not passed. However, this test would also succeed if the configuration required only one header. As Apache's configuration is notoriously tricky (this developer frequently requires StackOverflow's help to understand Apache's documentation), especially when still supporting the 2.2 line, let's just really make sure that the test verifies what we want it to verify. Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de> Reviewed-by: Jeff King <peff@peff.net> Signed-off-by: Junio C Hamano <gitster@pobox.com>
Johannes Schindelin committed
May 9, 2016 at 08:19 UTC
e31165ce69ef3986e8b5477d52cc7d4e19b4212d
1 file changed
+2
-1
t/t5551-http-fetch-smart.sh
+2
-1
@@ -283,7 +283,8 @@ test_expect_success EXPENSIVE 'http can handle enormous ref negotiation' '
283
'
284
285
test_expect_success 'custom http headers' '
286
- test_must_fail git fetch "$HTTPD_URL/smart_headers/repo.git" &&
286
+ test_must_fail git -c http.extraheader="x-magic-two: cadabra" \
287
+ fetch "$HTTPD_URL/smart_headers/repo.git" &&
288
git -c http.extraheader="x-magic-one: abra" \
289
-c http.extraheader="x-magic-two: cadabra" \
290
fetch "$HTTPD_URL/smart_headers/repo.git"