t/t3600-rm.sh: use the $( ... ) construct for command substitution
The Git CodingGuidelines prefer the $(...) construct for command substitution instead of using the backquotes `...`. The backquoted form is the traditional method for command substitution, and is supported by POSIX. However, all but the simplest uses become complicated quickly. In particular, embedded command substitutions and/or the use of double quotes require careful escaping with the backslash character. The patch was generated by: for _f in $(find . -name "*.sh") do perl -i -pe 'BEGIN{undef $/;} s/`(.+?)`/\$(\1)/smg' "${_f}" done and then carefully proof-read. Signed-off-by: Elia Pinto <gitter.spiros@gmail.com> Signed-off-by: Junio C Hamano <gitster@pobox.com>
Elia Pinto committed
Dec 22, 2015 at 16:27 UTC
e3ab3bc22ba37807755f95e90179323eb941e56a
1 file changed
+2
-2
t/t3600-rm.sh
+2
-2
@@ -115,7 +115,7 @@ test_expect_success '"rm" command printed' '
115
git add test-file &&
116
git commit -m "add file for rm test" &&
117
git rm test-file > rm-output &&
118
- test `grep "^rm " rm-output | wc -l` = 1 &&
118
+ test $(grep "^rm " rm-output | wc -l) = 1 &&
119
rm -f test-file rm-output &&
120
git commit -m "remove file from rm test"
121
'
@@ -125,7 +125,7 @@ test_expect_success '"rm" command suppressed with --quiet' '
125
git add test-file &&
126
git commit -m "add file for rm --quiet test" &&
127
git rm --quiet test-file > rm-output &&
128
- test `wc -l < rm-output` = 0 &&
128
+ test $(wc -l < rm-output) = 0 &&
129
rm -f test-file rm-output &&
130
git commit -m "remove file from rm --quiet test"
131
'