Makefile: always (re)set DC_SHA1 on fallback

Fix an edge case introduced in in e6b07da2780 (Makefile: make DC_SHA1 the default, 2017-03-17), when DC_SHA1 was made the default fallback we started unconditionally adding to BASIC_CFLAGS and LIB_OBJS, so we'd use the sha1collisiondetection by default. But the "DC_SHA1" variable remained unset, so e.g.: make test DC_SHA1= T=t0013*.sh Would skip the sha1collisiondetection tests, as we'd write "DC_SHA1=''" to "GIT-BUILD-OPTIONS", but if we manually removed that test prerequisite we'd pass the test (which we couldn't if we weren't using sha1collisiondetection). So let's have the fallback assignment use the 'override' directive instead of the ":=" simply expanded variable introduced in e6b07da2780. In this case we explicitly want to override the user's choice. Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com> Signed-off-by: Taylor Blau <me@ttaylorr.com>

Ævar Arnfjörð Bjarmason committed Nov 7, 2022 at 22:23 UTC e47913e8e29fdeaa26ccdf2626894da5283d9bd8
1 file changed +1 -1
Makefile
+1 -1
@@ -1826,7 +1826,7 @@ ifdef APPLE_COMMON_CRYPTO
1826 COMPAT_CFLAGS += -DCOMMON_DIGEST_FOR_OPENSSL
1827 BASIC_CFLAGS += -DSHA1_APPLE
1828 else
1829 - DC_SHA1 := YesPlease
1829 + override DC_SHA1 = YesPlease
1830 BASIC_CFLAGS += -DSHA1_DC
1831 LIB_OBJS += sha1dc_git.o
1832 ifdef DC_SHA1_EXTERNAL