refs.c: fix fread error handling
fread returns the number of items read, with no special error return. Commit 98f85ff (reflog: add for_each_reflog_ent_reverse() API - 2013-03-08) introduced a call to fread which checks for an error with "nread < 0" which is tautological since nread is unsigned. The correct check in this case (which tries to read a single item) is "nread != 1". Signed-off-by: John Keeping <john@keeping.me.uk> Signed-off-by: Junio C Hamano <gitster@pobox.com>
John Keeping committed
Mar 23, 2013 at 17:16 UTC
e4ca819abff48af8e4a10059c88b3b1533b9f994
1 file changed
+1
-1
refs.c
+1
-1
@@ -2357,7 +2357,7 @@ int for_each_reflog_ent_reverse(const char *refname, each_reflog_ent_fn fn, void
2357
return error("cannot seek back reflog for %s: %s",
2358
refname, strerror(errno));
2359
nread = fread(buf, cnt, 1, logfp);
2360
- if (nread < 0)
2360
+ if (nread != 1)
2361
return error("cannot read %d bytes from reflog for %s: %s",
2362
cnt, refname, strerror(errno));
2363
pos -= cnt;