commit: release strbuf on error return in commit_tree_extended()
Signed-off-by: Rene Scharfe <l.s.r@web.de> Signed-off-by: Junio C Hamano <gitster@pobox.com>
Rene Scharfe committed
Aug 30, 2017 at 19:49 UTC
e505146dac276cc051eca199f9dc7ca88bef5f18
1 file changed
+5
-2
commit.c
+5
-2
@@ -1564,10 +1564,13 @@ int commit_tree_extended(const char *msg, size_t msg_len,
1564
if (encoding_is_utf8 && !verify_utf8(&buffer))
1565
fprintf(stderr, _(commit_utf8_warn));
1566
1567
- if (sign_commit && do_sign_commit(&buffer, sign_commit))
1568
- return -1;
1567
+ if (sign_commit && do_sign_commit(&buffer, sign_commit)) {
1568
+ result = -1;
1569
+ goto out;
1570
+ }
1571
1572
result = write_sha1_file(buffer.buf, buffer.len, commit_type, ret);
1573
+out:
1574
strbuf_release(&buffer);
1575
return result;
1576
}