@matheusbsbs / matheus-bagliano / commits / e596acc23a

preload-index: avoid lstat for skip-worktree items

Teach preload-index to avoid lstat() calls for index-entries with skip-worktree bit set. This is a performance optimization. During a sparse-checkout, the skip-worktree bit is set on items that were not populated and therefore are not present in the worktree. The per-thread preload-index loop performs a series of tests on each index-entry as it attempts to compare the worktree version with the index and mark them up-to-date. This patch short-cuts that work. On a Windows 10 system with a very large repo (450MB index) and various levels of sparseness, performance was improved in the {preloadindex=true, fscache=false} case by 80% and in the {preloadindex=true, fscache=true} case by 20% for various commands. Signed-off-by: Jeff Hostetler <jeffhost@microsoft.com> Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de> Signed-off-by: Junio C Hamano <gitster@pobox.com>

Jeff Hostetler committed Feb 10, 2017 at 16:10 UTC e596acc23a8c92784349da613502626d758215b2

1 file changed +2

preload-index.c

@@ -53,6 +53,8 @@ static void *preload_thread(void *_data)

53 continue;

54 if (ce_uptodate(ce))

55 continue;

56 + if (ce_skip_worktree(ce))

57 + continue;

58 if (!ce_path_match(ce, &p->pathspec, NULL))

59 continue;

60 if (threaded_has_symlink_leading_path(&cache, ce->name, ce_namelen(ce)))