run-command: mark unused async callback parameters
The start_async(), etc, functions need a "proc" callback that conforms to a particular interface. Not every callback needs every parameter (e.g., the caller might not even ask to open an input descriptor, in which case there is no point in the callback looking at it). Let's mark these for -Wunused-parameter. Signed-off-by: Jeff King <peff@peff.net> Signed-off-by: Junio C Hamano <gitster@pobox.com>
Jeff King committed
Aug 19, 2022 at 06:08 UTC
e5e056b21dc5c128b5349ac336c6315943e88dee
4 files changed
+4
-4
builtin/receive-pack.c
+1
-1
@@ -465,7 +465,7 @@ static void rp_error(const char *err, ...)
465
va_end(params);
466
}
467
468
-static int copy_to_sideband(int in, int out, void *arg)
468
+static int copy_to_sideband(int in, int UNUSED(out), void *UNUSED(arg))
469
{
470
char data[128];
471
int keepalive_active = 0;
convert.c
+1
-1
@@ -619,7 +619,7 @@ struct filter_params {
619
const char *path;
620
};
621
622
-static int filter_buffer_or_fd(int in, int out, void *data)
622
+static int filter_buffer_or_fd(int UNUSED(in), int out, void *data)
623
{
624
/*
625
* Spawn cmd and feed the buffer contents through its stdin.
fetch-pack.c
+1
-1
@@ -823,7 +823,7 @@ static int everything_local(struct fetch_pack_args *args,
823
return retval;
824
}
825
826
-static int sideband_demux(int in, int out, void *data)
826
+static int sideband_demux(int UNUSED(in), int out, void *data)
827
{
828
int *xd = data;
829
int ret;
send-pack.c
+1
-1
@@ -266,7 +266,7 @@ static int receive_status(struct packet_reader *reader, struct ref *refs)
266
return ret;
267
}
268
269
-static int sideband_demux(int in, int out, void *data)
269
+static int sideband_demux(int UNUSED(in), int out, void *data)
270
{
271
int *fd = data, ret;
272
if (async_with_fork())