resolve_ref_1(): reorder code
There is no need to adjust *flags if we're just about to fail. Signed-off-by: Michael Haggerty <mhagger@alum.mit.edu> Signed-off-by: David Turner <dturner@twopensource.com> Signed-off-by: Junio C Hamano <gitster@pobox.com>
Michael Haggerty committed
Apr 7, 2016 at 15:02 UTC
e6702e570ba4a8501362594b66b74d0ecff002dd
1 file changed
+2
-2
refs/files-backend.c
+2
-2
@@ -1542,13 +1542,13 @@ static const char *resolve_ref_1(const char *refname,
1542
return refname;
1543
}
1544
if (check_refname_format(refname, REFNAME_ALLOW_ONELEVEL)) {
1545
- *flags |= REF_ISBROKEN;
1546
-
1545
if (!(resolve_flags & RESOLVE_REF_ALLOW_BAD_NAME) ||
1546
!refname_is_safe(refname)) {
1547
errno = EINVAL;
1548
return NULL;
1549
}
1550
+
1551
+ *flags |= REF_ISBROKEN;
1552
bad_name = 1;
1553
}
1554
}