builtin/bundle.c: remove superfluous "newargc" variable
As noted in 891cb09db6c (bundle: don't segfault on "git bundle <subcmd>", 2022-12-20) the "newargc" in this function is redundant to using our own "argc". Let's refactor the function to avoid needlessly introducing another variable. Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com> Signed-off-by: Junio C Hamano <gitster@pobox.com>
Ævar Arnfjörð Bjarmason committed
Dec 27, 2022 at 19:39 UTC
e778ecbcee3a4a14e46c06d66328fdfc0af8780d
1 file changed
+3
-4
builtin/bundle.c
+3
-4
@@ -45,13 +45,12 @@ static int parse_options_cmd_bundle(int argc,
45
const char * const usagestr[],
46
const struct option options[],
47
char **bundle_file) {
48
- int newargc;
49
- newargc = parse_options(argc, argv, NULL, options, usagestr,
48
+ argc = parse_options(argc, argv, NULL, options, usagestr,
49
PARSE_OPT_STOP_AT_NON_OPTION);
51
- if (!newargc)
50
+ if (!argc)
51
usage_with_options(usagestr, options);
52
*bundle_file = prefix_filename(prefix, argv[0]);
54
- return newargc;
53
+ return argc;
54
}
55
56
static int cmd_bundle_create(int argc, const char **argv, const char *prefix) {